`weak_rng_crypto`

CWE-338

Weak Rng Crypto — a PullGuard finding type. Findings of this type appear in the PR comment, Step Summary, SARIF (GitHub Security tab / IDE viewers), and the HTML report, each with severity, location, and the remediation guidance below.

How to fix

Use crypto.randomBytes / secrets / SecureRandom for security-sensitive randomness trivial effort

// WRONG — Math.random() is NOT cryptographic
const token = Math.random().toString(36);

// RIGHT — Node
import crypto from "node:crypto";
const token = crypto.randomBytes(32).toString("hex");

// RIGHT — Python
import secrets
token = secrets.token_hex(32)

// RIGHT — Java
SecureRandom sr = new SecureRandom();

Triage

Suppress a confirmed non-issue with a committed .pullguardignore entry (pullguard ignore locally, or comment /pullguard ignore <fingerprint> <reason> on the PR — the fingerprint is printed in the PR comment’s Triage section). Entries support expiresAt for time-boxed snoozes.

Security findings at major or critical severity — and any critical finding — always surface: .pullguardignore cannot hide them. The reviewed paths that keep them visible are acknowledged (reviewed, stays in reports) and, for a confirmed false positive, a reasoned false_positive entry — visible and audited, excluded only from the merge block.