← All finding types

empty_catch_block

CWE-390

Empty Catch Block — a PullGuard finding type. Findings of this type appear in the PR comment, Step Summary, SARIF (GitHub Security tab / IDE viewers), and the HTML report, each with severity, location, and the remediation guidance below.

How to fix

Handle, rethrow, or explicitly document the swallowed error low effort

// Before (SILENT FAILURE):
try { await syncInventory(); } catch (e) {}

// After — handle:
try { await syncInventory(); } catch (e) { logger.warn("inventory sync failed", e); }

// Or, when ignoring is genuinely correct, SAY WHY (a commented catch is not flagged):
try { await bestEffortPrefetch(); } catch { /* prefetch is optional — page still renders */ }

# Python:
try:
    refresh_cache()
except CacheError:
    logger.warning("cache refresh failed; serving stale")

Triage

Suppress a confirmed non-issue with a committed .pullguardignore entry (pullguard ignore locally, or comment /pullguard ignore <fingerprint> <reason> on the PR — the fingerprint is printed in the PR comment’s Triage section). Entries support expiresAt for time-boxed snoozes.

Security findings at major or critical severity — and any critical finding — always surface: .pullguardignore cannot hide them. The reviewed paths that keep them visible are acknowledged (reviewed, stays in reports) and, for a confirmed false positive, a reasoned false_positive entry — visible and audited, excluded only from the merge block.